Add tests for hide warnings and auto compile options

ethereum · Nov 2, 2023 · 1701c53 · 1701c53
1 parent f61d10b
commit 1701c53
Show file tree

Hide file tree

Showing 3 changed files with 94 additions and 6 deletions.
diff --git a/apps/circuit-compiler/src/app/components/feedback.tsx b/apps/circuit-compiler/src/app/components/feedback.tsx
@@ -21,7 +21,7 @@ export function CompilerFeedback ({ feedback, filePathToId, hideWarnings, openEr
     <div>
       <div className="circuit_errors_box py-4">
         <RenderIf condition={ (typeof feedback === "string") && showException }>
-          <div className="circuit_feedback error alert alert-danger">
+          <div className="circuit_feedback error alert alert-danger" data-id="circuit_feedback">
             <span> { feedback } </span>
             <div className="close" data-id="renderer" onClick={handleCloseException}>
               <i className="fas fa-times"></i>
@@ -39,12 +39,12 @@ export function CompilerFeedback ({ feedback, filePathToId, hideWarnings, openEr
               Array.isArray(feedback) && feedback.map((response, index) => (
                 <div key={index} onClick={() => handleOpenError(response)}>
                   <RenderIf condition={response.type === 'Error'}>
-                    <div className={`circuit_feedback ${response.type.toLowerCase()} alert alert-danger`}>
+                    <div className={`circuit_feedback ${response.type.toLowerCase()} alert alert-danger`} data-id="circuit_feedback">
                       <FeedbackAlert message={response.message} location={ response.labels[0] ? response.labels[0].message + ` ${filePathToId[response.labels[0].file_id]}:${response.labels[0].range.start}:${response.labels[0].range.end}` : null} />
                     </div>
                   </RenderIf>
                   <RenderIf condition={(response.type === 'Warning') && !hideWarnings}>
-                    <div className={`circuit_feedback ${response.type.toLowerCase()} alert alert-warning`}>
+                    <div className={`circuit_feedback ${response.type.toLowerCase()} alert alert-warning`} data-id="circuit_feedback">
                       <FeedbackAlert message={response.message} location={null} />
                     </div>
                   </RenderIf>

diff --git a/apps/circuit-compiler/src/app/components/options.tsx b/apps/circuit-compiler/src/app/components/options.tsx
@@ -14,7 +14,7 @@ export function CompileOptions ({autoCompile, hideWarnings, setCircuitAutoCompil
           checked={autoCompile}
           id="autoCompileCircuit"
         />
-        <label className="form-check-label custom-control-label" htmlFor="autoCompileCircuit">
+        <label className="form-check-label custom-control-label" htmlFor="autoCompileCircuit" data-id="auto_compile_circuit_checkbox_input">
           <FormattedMessage id="circuit.autoCompile" />
         </label>
       </div>
@@ -27,7 +27,7 @@ export function CompileOptions ({autoCompile, hideWarnings, setCircuitAutoCompil
           title="Hide warnings"
           checked={hideWarnings}
         />
-        <label className="form-check-label custom-control-label" htmlFor="hideCircuitWarnings">
+        <label className="form-check-label custom-control-label" htmlFor="hideCircuitWarnings" data-id="hide_circuit_warnings_checkbox_input">
           <FormattedMessage id="solidity.hideWarnings" />
         </label>
       </div>

diff --git a/apps/remix-ide-e2e/src/tests/circom.test.ts b/apps/remix-ide-e2e/src/tests/circom.test.ts
@@ -8,7 +8,7 @@ module.exports = {
     init(browser, done)
   },
 
-  'Should create semaphore workspace template #group1 #group2 #group3': function (browser: NightwatchBrowser) {
+  'Should create semaphore workspace template #group1 #group2 #group3 #group4': function (browser: NightwatchBrowser) {
     browser
       .clickLaunchIcon('filePanel')
       .click('*[data-id="workspacesMenuDropdown"]')
@@ -92,5 +92,93 @@ module.exports = {
       })
       .waitForElementPresent('[data-id="treeViewLitreeViewItemcircuits/.bin/simple.wasm"]')
       .waitForElementVisible('[data-id="treeViewLitreeViewItemcircuits/.bin/simple.wasm"]')
+  },
+  'Should display warnings for compiled circuit without pragma version #group4': function (browser: NightwatchBrowser) {
+    browser
+      .addFile('circuits/warning.circom', { content: warningCircuit })
+      .waitForElementPresent('[data-path="Semaphore - 1/circuits/warning.circom"]')
+      .waitForElementVisible('[data-path="Semaphore - 1/circuits/warning.circom"]')
+      .click('[data-id="treeViewLitreeViewItemcircuits/warning.circom"]')
+      .clickLaunchIcon('circuit-compiler')
+      .frame(0)
+      .waitForElementPresent('button[data-id="compile_circuit_btn"]')
+      .waitForElementVisible('button[data-id="compile_circuit_btn"]')
+      .click('button[data-id="compile_circuit_btn"]')
+      .waitForElementPresent('[data-id="circuit_feedback"]')
+      .assert.hasClass('[data-id="circuit_feedback"]', 'alert-warning')
+      .waitForElementContainsText('[data-id="circuit_feedback"]', 'File circuits/warning.circom does not include pragma version. Assuming pragma version (2, 1, 5)')
+  },
+  'Should hide/show warnings for compiled circuit #group4': function (browser: NightwatchBrowser) {
+    browser
+      .click('[data-id="hide_circuit_warnings_checkbox_input"]')
+      .waitForElementNotPresent('[data-id="circuit_feedback"]')
+      .click('[data-id="hide_circuit_warnings_checkbox_input"]')
+      .waitForElementVisible('[data-id="circuit_feedback"]')
+      .waitForElementContainsText('[data-id="circuit_feedback"]', 'File circuits/warning.circom does not include pragma version. Assuming pragma version (2, 1, 5)')
+  },
+  'Should display error for invalid circuit #group4': function (browser: NightwatchBrowser) {
+    browser
+      .frameParent()
+      .clickLaunchIcon('filePanel')
+      .addFile('circuits/error.circom', { content: errorCircuit })
+      .waitForElementPresent('[data-path="Semaphore - 1/circuits/error.circom"]')
+      .waitForElementVisible('[data-path="Semaphore - 1/circuits/error.circom"]')
+      .click('[data-id="treeViewLitreeViewItemcircuits/error.circom"]')
+      .clickLaunchIcon('circuit-compiler')
+      .frame(0)
+      .waitForElementPresent('button[data-id="compile_circuit_btn"]')
+      .waitForElementVisible('button[data-id="compile_circuit_btn"]')
+      .click('button[data-id="compile_circuit_btn"]')
+      .waitForElementPresent('[data-id="circuit_feedback"]')
+      .assert.hasClass('[data-id="circuit_feedback"]', 'alert-danger')
+      .waitForElementContainsText('[data-id="circuit_feedback"]', 'No main specified in the project structure')
+  },
+  'Should auto compile circuit #group4': function (browser: NightwatchBrowser) {
+    browser
+      .click('[data-id="auto_compile_circuit_checkbox_input"]')
+      .frameParent()
+      .setEditorValue(validCircuit, function () {
+        browser
+          .frame(0)
+          .waitForElementNotPresent('[data-id="circuit_feedback"]')
+          .frameParent()
+          .clickLaunchIcon('filePanel')
+          .waitForElementPresent('[data-id="treeViewLitreeViewItemcircuits/.bin/error.wasm"]')
+      })
   }
 }
+
+const warningCircuit = `
+template Multiplier2() {
+  signal input a;
+  signal input b;
+  signal output c;
+  c <== a*b;
+}
+
+component main = Multiplier2();
+`
+
+const errorCircuit = `
+pragma circom 2.0.0;
+
+template Multiplier2() {
+    signal input a;
+    signal input b;
+    signal output c;
+    c <== a*b;
+ }
+`
+
+const validCircuit = `
+pragma circom 2.0.0;
+
+template Multiplier2() {
+    signal input a;
+    signal input b;
+    signal output c;
+    c <== a*b;
+ }
+
+ component main = Multiplier2();
+`