Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EIP3860 after Shanghai upgrade #3640

Closed
rayeaster opened this issue Apr 20, 2023 · 0 comments · Fixed by #3650
Closed

Support EIP3860 after Shanghai upgrade #3640

rayeaster opened this issue Apr 20, 2023 · 0 comments · Fixed by #3650
Assignees
@yann300

Comments

@rayeaster
Copy link

With EIP 3860, the contract size limit should be doubled from 24KB to 48KB?

https://github.com/ethereum/remix-project/blob/master/libs/remix-ui/run-tab/src/lib/actions/deploy.ts#L70

-  return (deployedBytecode && deployedBytecode.object.length / 2 > 24576)
+ return (deployedBytecode && deployedBytecode.object.length / 2 > 24576 * 2)

and some locales to fix
https://github.com/ethereum/remix-project/blob/master/apps/remix-ide/src/app/tabs/locales/en/udapp.json#L30
https://github.com/ethereum/remix-project/blob/master/apps/remix-ide/src/app/tabs/locales/zh/udapp.json#L30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yann300 yann300

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eip3860 ethereum/remix-project
2 participants
@rayeaster @yann300