New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Etherscan issues part 2 #3813

Closed

2 of 3 tasks

LianaHus opened this issue Jun 19, 2023 · 1 comment · Fixed by #3868

Closed

2 of 3 tasks

Etherscan issues part 2 #3813

LianaHus opened this issue Jun 19, 2023 · 1 comment · Fixed by #3868

Assignees

Labels

STORY

Collaborator

LianaHus commented Jun 19, 2023 •

edited by Aniket-Engg

Loading

part 1 is here #3597

To keep this consistency with other parts of the ide we need to use in-place value verification(for example 'required' error msg if the address is empty) instead of toasters ( we are minimizing the usage of toasters through the app.)
When VM is selected in D&R we need to disable the Verify button and the label should be 'VM - not supported" in the env field
The active icon from the header menu of the plugin should be brighter.

LianaHus assigned Aniket-Engg

ryestew added the STORY label

Aniket-Engg mentioned this issue

disable verify for not supported VM #3840

Merged

Collaborator

ryestew commented Jun 26, 2023

There is the api key input in the plugin and also in the settings panel. When is the one in the settings panel used?

Aniket-Engg mentioned this issue

toasters removed from Etherscan plugin #3868

Merged

Aniket-Engg closed this as completed in #3868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment