Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etherscan Plugin Improvement and fixes #3597

Closed
9 tasks done
Aniket-Engg opened this issue Apr 4, 2023 · 4 comments · Fixed by #3771
Closed
9 tasks done

Etherscan Plugin Improvement and fixes #3597

Aniket-Engg opened this issue Apr 4, 2023 · 4 comments · Fixed by #3771
Assignees

Comments

@Aniket-Engg
Copy link
Collaborator

Aniket-Engg commented Apr 4, 2023

As per current status:

  • Nothing happens on clicking icons if no API key provided. Actually that is a feature but user has no idea what to do next.
  • After providing API key, clicking on Save, no message appears.
  • No check on API key length

Home Tab:

  • Form validation improvement, unnecessary cross icon
  • Show constructor arguments field conditionally if required
  • Show error in red.
  • Show selected network in the plugin itself in read-only text

Receipts:

  • Requests seems to pending in queue forever

Settings:

  • Show API key in dots
@Aniket-Engg Aniket-Engg self-assigned this Apr 5, 2023
@yann300
Copy link
Contributor

yann300 commented Apr 5, 2023

  • Unable to verify contracts which has openzeppelin imports.
  • Unable to verify contracts that uses proxy.

@Aniket-Engg
Copy link
Collaborator Author

Aniket-Engg commented Apr 19, 2023

Suggestions from @LianaHus

  • Make Generate Verification Scripts button secondary
  • Add padding throughout the plugin UI
  • Disable Verify Contract button when not all fields are provided

@LianaHus
Copy link
Collaborator

LianaHus commented Apr 24, 2023

  • titles
  • font awsome icons instead of svg's

@Aniket-Engg
Copy link
Collaborator Author

Aniket-Engg commented May 16, 2023

  • Add a user-friendly way for encoded constructor arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants