Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close all tabs when workspace changes #1105

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Close all tabs when workspace changes #1105

merged 3 commits into from
Apr 12, 2021

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Apr 12, 2021

fix #989

@ryestew
Copy link
Collaborator

ryestew commented Apr 12, 2021

I think there are a couple of issues.

  1. when a learneth file is loaded - so it coming from a .learneth folder
  2. a gist
  3. when the workspace name has been changed.

I will double check there problems to see if I can recreate the problems.

@ryestew
Copy link
Collaborator

ryestew commented Apr 12, 2021

image

I seem to have 2 Readme s up - I'm on workspace_1 -but I have readme from workspace_1 and workspace_2

@ryestew
Copy link
Collaborator

ryestew commented Apr 12, 2021

Ahhh - so files with the same name in different workspaces have problems turning off

@ryestew
Copy link
Collaborator

ryestew commented Apr 12, 2021

I'm in workspace_2 and I see

image

The workspace name is appearing in the tab and it shouldn't

@ryestew
Copy link
Collaborator

ryestew commented Apr 12, 2021

and by going back and forth between workspaces I eventually got this:
image

the same contract repeated (1_Storage.sol)

Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there:
I am not getting files with the same names opening when I switch workspaces.

But:
If I have 16 tab open (or 1 tab- but it could be more annoying if I have a lot of tabs open)
and I switch workspaces - when I come back my first workspace - all the tabs (except the home tab) are closed. We could merge this as is and then work on the improvement in the next release.

@EthereumRemix EthereumRemix merged commit bd07c52 into master Apr 12, 2021
@EthereumRemix EthereumRemix deleted the closeAllTabs branch April 12, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: when switching between localhost & workspaces - the localhost files are still there
3 participants