Fixsolc #3667
Merged
Fixsolc #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
md5sum fix lint restore cache use file use caching fix config config fix grep fix lint nightly catch webpack url curl check curl use plus install jq use npx do not use jq rename cache filter duplicates manual versions fix manual v3 8.18 fix urls 7.6 fix regex fix latest remixd rename
ioedeveloper
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of brute forcing all versions of solc in e2e to be used locally we can regex the used versions out of the ts files, adding some manually that don't get detected. so it's about 95mb instead of 1Gb
These can be easily cached by circleCI so we don't have to reload them each time.
Also use curl for all these operations, seems more reliable. Axios was giving inconsistent results since the node v20 upgrade.
same for the local soljson, it's loaded with curl now.
The latest version is also added to the e2e versions because the tests will load it.