Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support More Etherscan explorers for contract verification #3709

Merged
merged 4 commits into from
May 17, 2023

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented May 17, 2023

Fixes #2757

Here is the list of explorers: https://etherscan.io/eaas

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 356d7e1
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/646494d968ad18000856b6e3
😎 Deploy Preview https://deploy-preview-3709--remixproject.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Aniket-Engg Aniket-Engg requested a review from yann300 May 17, 2023 08:47
@Aniket-Engg Aniket-Engg added ready-to-review PR ready to review etherscan documentation-needed Documentation should be updated labels May 17, 2023
@@ -1,7 +1,7 @@
{
"name": "etherscan",
"displayName": "Etherscan - Contract verification",
"description": "Verify Solidity contract code using Etherscan API",
"displayName": "Contract verification - Etherscan",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -43,7 +43,7 @@ export const DisplayRoutes = () => (
</DefaultLayout>} />
<Route
path="/settings"
element={<DefaultLayout from="/settings" title="Set Etherscan API Key">
element={<DefaultLayout from="/settings" title="Set Explorer API Key">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if each explorer has a different api key, we should probably allow specifying an api key per explorer.. (

@Aniket-Engg Aniket-Engg merged commit 7ad68aa into master May 17, 2023
@Aniket-Engg Aniket-Engg deleted the moreScans branch May 17, 2023 14:47
@Aniket-Engg Aniket-Engg mentioned this pull request May 25, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-needed Documentation should be updated etherscan ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for other explorer same as Etherscan in contract verifier plugin
2 participants