Manage generated sources #374
Conversation
yann300
force-pushed
the
manage_generatedSources
branch
from
2910041
to
55d89d5
Compare
yann300
force-pushed
the
manage_generatedSources
branch
2 times, most recently
from
1dcf7ba
to
fa6d766
Compare
yann300
force-pushed
the
manage_generatedSources
branch
8 times, most recently
from
e3c2488
to
ba8245e
Compare
yann300
added
remix-debug
enhancement
yann300
force-pushed
the
manage_generatedSources
branch
2 times, most recently
from
7b88f1a
to
6fee8e7
Compare
| @@ -12,7 +12,7 @@ const isObject = function(obj: any): boolean { | |||
| export function isAstNode(node: Record<string, unknown>): boolean { | |||
| return ( | |||
| isObject(node) && | |||
| 'id' in node && | |||
| // 'id' in node && | |||
There was a problem hiding this comment.
the id is removed because it seems YulBlock ast nodes don't have ids...
yann300
force-pushed
the
manage_generatedSources
branch
5 times, most recently
from
00f70c0
to
ffc1d05
Compare
yann300
force-pushed
the
manage_generatedSources
branch
4 times, most recently
from
6065f31
to
15951fe
Compare
yann300
force-pushed
the
manage_generatedSources
branch
from
89baf27
to
2eb0e58
Compare
| let content | ||
| try { | ||
| content = await this.debuggerModule.call('fileManager', 'getFile', path, source.contents) | ||
| } catch (e) {} |
There was a problem hiding this comment.
May be it can be better to at least log this error in console
| @@ -186,12 +227,18 @@ class DebuggerUI { | |||
| this.stepManagerView = yo`<div class="px-2"></div>` | |||
|
|
|||
| var view = yo` | |||
| <div> | |||
| <div> | |||
| <p class="mt-2 ${css.debuggerLabel}">Debugger Configuration</p> | ||
| <div class="mt-2 ${css.debuggerConfig} custom-control custom-checkbox"> | ||
| <input class="custom-control-input" id="debugGeneratedSourcesInput" onchange=${(event) => { this.opt.debugWithGeneratedSources = event.target.checked }} type="checkbox" title="Debug with generated sources"> | ||
| <label data-id="debugGeneratedSourcesLabel" class="form-check-label custom-control-label" for="debugGeneratedSourcesInput">Debug Generated sources if available (from Solidity 0.7.2)</label> |
There was a problem hiding this comment.
Minor correction: Debug Generated sources if available (from Solidity 0.7.2) => Debug generated sources if available (from Solidity v0.7.2)
Also can we check the compiler version from compilation data and show checkbox only if Solidity version is greater than v0.7.1 (That can be done in separate PR too)
There was a problem hiding this comment.
Also can we check the compiler version from compilation data and show checkbox only if Solidity version is greater than v0.7.1 (That can be done in separate PR too)
That might be a bit complicated... cause we are also using sourcify for retrieving the compiler version.
i.e when the user input a transaction hash and click debug, we fetch the metadata.json and this is only at this point of time that we know the compiler version...
| @@ -1,6 +1,6 @@ | |||
| import tape from "tape"; | |||
| import { | |||
| AstNode, isAstNode, | |||
| AstNode, isAstNode , | |||
| @@ -0,0 +1,57 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
This file was removed to use remix-astwalker npm package. Is there any need to bring it back?
linked to ethereum/solidity#8807 (comment)
work with this soljson build https://417293-40892817-gh.circle-artifacts.com/0/soljson.js