fix vm fork #3796
Merged
fix vm fork #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yann300
force-pushed
the
fix_vm_fork
branch
15 times, most recently
from
49373ba
to
f4d5a4a
Compare
ryestew
approved these changes
Jun 14, 2023
|
|
||
| class CustomEthersStateManager extends StateManagerCommonStorageDump { | ||
| private provider: ethers.providers.StaticJsonRpcProvider | ethers.providers.JsonRpcProvider | ||
| private blockTag: string |
There was a problem hiding this comment.
blockTag type definition (string) does not match it's type definition on line 93 (bigint | 'earliest')
| } else if (opts.provider instanceof ethers.providers.JsonRpcProvider) { | ||
| this.provider = opts.provider | ||
| } else { | ||
| throw new Error(`valid JsonRpcProvider or url required; got ${opts.provider}`) |
There was a problem hiding this comment.
provider can be of 3 types string | ethers.providers.StaticJsonRpcProvider | ethers.providers.JsonRpcProvider. Shouldn't there be a third check for else if (opts.provider instanceof ethers.providers.StaticJsonRpcProvider) before the else statement?
There was a problem hiding this comment.
StaticJsonRpcProvider is a JsonRpcProvider so it should just respond true to that check.
ioedeveloper
approved these changes
Jun 14, 2023
yann300
force-pushed
the
fix_vm_fork
branch
3 times, most recently
from
9e53fa6
to
d390adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite of the CustomEthersStateManager.
the previous implementation didn't handle well the checkpoint/revert.
in order to test it: