SSA Improvements #3892
Merged
SSA Improvements #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
ssa-improvements
branch
from
29d8b96
to
5aeb71b
Compare
Aniket-Engg
reviewed
Jul 5, 2023
Aniket-Engg
reviewed
Jul 6, 2023
| result.errCol = position ? parseInt(position[3]) : -1 | ||
| let position = msg.match(/^(.*?):([0-9]*?):([0-9]*?)?/); | ||
| result.errLine = position ? parseInt(position[2]) - 1 : -1; | ||
| result.errCol = position ? parseInt(position[3]) : -1; |
There was a problem hiding this comment.
If you find it fine, I think we can remove all semicolons
There was a problem hiding this comment.
yeah its the formatter I was experimenting with. missed removing those
| @@ -198,12 +207,13 @@ slitherEnabled: boolean, setStartAnalysis: React.Dispatch<React.SetStateAction<b | |||
| props.analysisModule.call('terminal', 'log', { type: 'error', value: '[Slither Analysis]: Error occured! See remixd console for details.' }) | |||
| showWarnings(warningMessage, 'warningModuleName') | |||
| } | |||
| } else showWarnings(warningMessage, 'warningModuleName') | |||
| } else //showWarnings(warningMessage, 'warningModuleName') | |||
| }, [solhintEnabled, basicEnabled, slitherEnabled, showSlither]) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
just missed removing it
Aniket-Engg
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3882