udapp fixes #3895
Merged
udapp fixes #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LianaHus
commented
Jul 5, 2023
•
LianaHus
commented
- fixing badges for fork alert
- fixing paddings in function buttons
- btns are now disabled if input is required but not filled
- some small refactoring and fixes in some themes
- CSS style classes -> bootstrap
- coding style fixes
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LianaHus
requested review from
joeizang,
yann300,
ioedeveloper and
Aniket-Engg
and removed request for
joeizang and
yann300
Aniket-Engg
reviewed
Jul 6, 2023
| } | ||
| props.loadAddress(loadedContractData, address) | ||
| } catch(e) { | ||
| console.log("Invalid Address input: ", e) |
There was a problem hiding this comment.
why? We should improve UI error feedback. For now I would keep this.
Aniket-Engg
reviewed
Jul 6, 2023
There was a problem hiding this comment.
- Not sure if
No compiled contractscan be more visible. Also in tooltip text,AtAddress'can be replace withAt Address
At addressbutton looks enabled even if no address is provided- About the badges, I think we decided to remove
compiled by Remixfor non-remixd connection - Disabling the method name on no input parameters can be confusing for some users, can we have a tooltip when method button is disabled
done
done
done
we had. I'll check what's broken there |
Aniket-Engg
reviewed
Jul 10, 2023
| @@ -26,7 +26,7 @@ | |||
| "udapp.contractOptionsTitle1": "Please compile *.sol file to deploy or access a contract", | |||
| "udapp.contractOptionsTitle2": "Select a compiled contract to deploy or to use with At Address.", | |||
| "udapp.contractOptionsTitle3": "Select and compile *.sol file to deploy or access a contract.", | |||
| "udapp.contractOptionsTitle4": "When there is a compiled .sol file, choose the contract to deploy or to use with AtAddress.'", | |||
| "udapp.contractOptionsTitle4": "When there is a compiled .sol file, choose the contract to deploy or to use with At Address.'", | |||
There was a problem hiding this comment.
I think ' from the end can still be removed
| @@ -25,7 +25,7 @@ | |||
| "udapp.contractOptionsTitle1": "Please compile *.sol file to deploy or access a contract", | |||
| "udapp.contractOptionsTitle2": "Select a compiled contract to deploy or to use with At Address.", | |||
| "udapp.contractOptionsTitle3": "Select and compile *.sol file to deploy or access a contract.", | |||
| "udapp.contractOptionsTitle4": "When there is a compiled .sol file, choose the contract to deploy or to use with AtAddress.'", | |||
| "udapp.contractOptionsTitle4": "When there is a compiled .sol file, choose the contract to deploy or to use with At Address.'", | |||
| @@ -25,7 +25,7 @@ | |||
| "udapp.contractOptionsTitle1": "Please compile *.sol file to deploy or access a contract", | |||
| "udapp.contractOptionsTitle2": "Select a compiled contract to deploy or to use with At Address.", | |||
| "udapp.contractOptionsTitle3": "Select and compile *.sol file to deploy or access a contract.", | |||
| "udapp.contractOptionsTitle4": "When there is a compiled .sol file, choose the contract to deploy or to use with AtAddress.'", | |||
| "udapp.contractOptionsTitle4": "When there is a compiled .sol file, choose the contract to deploy or to use with At Address.'", | |||
Aniket-Engg
reviewed
Jul 10, 2023
|
If I provide an invalid type value for constructor params, deploy button is enabled. When I click on |
same on live. will fix it in second pr |
fixed by #3912 |
Aniket-Engg
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.