Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove File Explorer Redundant Caret Icon #3971

Merged
merged 9 commits into from
Aug 15, 2023
Merged

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Aug 7, 2023

fixes #3522

@joeizang joeizang added the ready-to-review PR ready to review label Aug 7, 2023
@joeizang joeizang self-assigned this Aug 7, 2023
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 2fd80f7
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/64db2157d5796b000879e342
😎 Deploy Preview https://deploy-preview-3971--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang force-pushed the remove-fe-caret branch 2 times, most recently from 0adf892 to 9eaafc4 Compare August 8, 2023 11:46
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-08-08 at 6 33 38 PM

I see asymmetry in UI for file actions icons. This should be improved

Copy link
Collaborator

@LianaHus LianaHus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github import doesn't work anymore
all cases when we add subrootfolder
also, I connected to remixd with a long folder list I can't scroll to the end

@joeizang
Copy link
Collaborator Author

github import doesn't work anymore all cases when we add subrootfolder also, I connected to remixd with a long folder list I can't scroll to the end

The remixd issue was always there @LianaHus and is not the result of anything done in this pr. I fixed the issue I think you are referring to with the padding with sub folders.

@LianaHus
Copy link
Collaborator

could you please add pb-1 on a span for menu items?
my other comment about remixd is fixed in my pr.

@Aniket-Engg Aniket-Engg merged commit 010f474 into master Aug 15, 2023
6 checks passed
@Aniket-Engg Aniket-Engg deleted the remove-fe-caret branch August 15, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caret in the File Explorer is not needed
3 participants