Intl patch3 #3992
Merged
Intl patch3 #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
drafish
force-pushed
the
intl-patch3
branch
2 times, most recently
from
0937a74
to
722c395
Compare
ryestew
reviewed
Sep 14, 2023
drafish
force-pushed
the
intl-patch3
branch
from
6a8ecef
to
35d4f7f
Compare
joeizang
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
index.jsfor Spanish and FrenchThis time, I didn't submit zh locale messages. I think it will be better if I upload zh locale json files on crowdin. And @ryestew will submit a pr from crowdin to update the non-english locale json.
Since crowdin is already handling the non-english languages, there is no need to maintain them manually. Because everything you update on non-english languages will be overwritten by crowdin.
For example, here is a pr that submitted by @LianaHus . I see you updated 4 languages. But actually you only need to update english. Other three will be updated by crowdin. And I think it will be better if non-english languages only be updated by crowdin, because it wouldn't cause any conflicts when merging crowdin pr.
And some times you will add some new strings, you probably will wonder if you need to add those new strings to non-english languages. The answer is still no. Because non-english languages will be filled in the gaps with english. Check the code below.
https://github.com/ethereum/remix-project/blob/master/apps/remix-ide/src/app/tabs/locales/zh/index.js#L15-L17
There is a situation that you need to notice. When you add a new json file, you need to add it in other languages and import it in
index.js. Otherwise, the translations wouldn't work.That's about everything. If you guys have any questions, feel free to ask me anytime.
The intl feature is coming from Remix CC, and we will provide long term support for it, and any other features that we probably will contribute in the future.