Monaco editor version update #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
force-pushed
the
monacoverUpdate
branch
from
fdc288a
to
8807352
Compare
Aniket-Engg
force-pushed
the
monacoverUpdate
branch
from
25396cf
to
76f9db5
Compare
|
These are default changes done in the newer version |
Aniket-Engg
requested review from
bunsenstraat,
yann300,
ioedeveloper,
joeizang,
ryestew and
LianaHus
and removed request for
bunsenstraat
ok but this should be fixed. we can discuss <> but selected line looks ugly it should be one of those two: |
LianaHus
requested changes
Aug 28, 2023
Aniket-Engg
force-pushed
the
monacoverUpdate
branch
from
bea7bbc
to
a9cfc2b
Compare
LianaHus
reviewed
Aug 30, 2023
| 'editor.lineHighlightBorder': secondaryColor, | ||
| 'editor.lineHighlightBackground': | ||
| textbackground === darkColor ? lightColor : secondaryColor, | ||
| 'editor.lineHighlightBorder': textbackground, |
There was a problem hiding this comment.
Why not set it the same as the highlight color? Looks narrow now
LianaHus
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.