Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write multiple files from plugin #4034

Merged
merged 4 commits into from
Aug 31, 2023
Merged

write multiple files from plugin #4034

merged 4 commits into from
Aug 31, 2023

Conversation

TylerSehr
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Aug 24, 2023

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 71de1f7

@joeizang
Copy link
Collaborator

@TylerSehr Hi. Can you please describe the motivation behind the pr. It helps quite a bit.

@TylerSehr
Copy link
Author

writeMultipleFiles allows for a plugin to add entire protocols to the remix editor, preserve the file structure for the protocols, and only prompt once to write the files into a single folder.

Currently plugins are able to do this using github gists, but that results in file collisions and certain files can be overwritten.

We're updating the Cookbook plugin to support full protocols, so we want to be able to import an entire protocol into remix.

Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerSehr
Copy link
Author

Added rename Cookbook Plugin

@Aniket-Engg Aniket-Engg merged commit d0b0263 into ethereum:master Aug 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants