fix filtering event #4088
Merged
fix filtering event #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
e2e will be added in #4089 |
yann300
force-pushed
the
fix_filteing_event
branch
from
f558495
to
fb40c40
Compare
bunsenstraat
approved these changes
Sep 26, 2023
yann300
force-pushed
the
fix_filteing_event
branch
from
07b22b7
to
ba10783
Compare
Aniket-Engg
force-pushed
the
fix_filteing_event
branch
from
a91265e
to
702e275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes 2 issues:
changeEvent.tx.to || '')instead of checking that the "to" is null, we do the check against thereceipt.contractAddresswhich contains the address of the newly created contract.log.addressinstead oftx.to, that way it won't obfuscate event emiitted from a call.