Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compilation details to Main panel plugin #4153

Merged
merged 10 commits into from
Oct 27, 2023

Conversation

joeizang
Copy link
Collaborator

No description provided.

@joeizang joeizang added the WIP label Oct 20, 2023
@joeizang joeizang self-assigned this Oct 20, 2023
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 31a5bef
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/653a94b03d334600073bb263
😎 Deploy Preview https://deploy-preview-4153--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang force-pushed the compiledetails-mainpanel-plugin branch from 142cd21 to 948722a Compare October 20, 2023 11:15
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Oct 24, 2023
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! It just needs a few fixes:

  • The carets disappear in the down state - see image below
  • In ? do the same thing as the carets - is that correct - if so they should be removed.
  • Click on bytecode and there is a lot of stuff - but it is not changing the right side scroll bar (which should be much much longer)(horizontal scroll does not reflect the contents either):
image

@joeizang
Copy link
Collaborator Author

This is great! It just needs a few fixes:

  • The carets disappear in the down state - see image below
  • In ? do the same thing as the carets - is that correct - if so they should be removed.
  • Click on bytecode and there is a lot of stuff - but it is not changing the right side scroll bar (which should be much much longer)(horizontal scroll does not reflect the contents either):
image
    1. The carets always disappeared and is the default behaviour.
    1. This is also the default behaviour. Maybe we keep this default behaviour and propose new behaviour for another pr?
    1. I am not sure but will try and wrap that and see how it looks.

@joeizang joeizang requested a review from ryestew October 24, 2023 21:22
@ryestew
Copy link
Collaborator

ryestew commented Oct 25, 2023

If it is the default behavior, then lets merge this and fix in another PR (which could be in the next release).

@joeizang joeizang force-pushed the compiledetails-mainpanel-plugin branch from 6764ed1 to 6f75b46 Compare October 26, 2023 09:00
@joeizang
Copy link
Collaborator Author

If it is the default behavior, then lets merge this and fix in another PR (which could be in the next release).

You will need to approve this. 😄

@yann300
Copy link
Contributor

yann300 commented Oct 26, 2023

just a thought, maybe the some of the important section could be unfolded by default...

@joeizang joeizang force-pushed the compiledetails-mainpanel-plugin branch from 6f75b46 to 2f33af4 Compare October 26, 2023 12:12
@joeizang joeizang force-pushed the compiledetails-mainpanel-plugin branch from 2f33af4 to 31a5bef Compare October 26, 2023 16:32
@joeizang joeizang merged commit 0460bd6 into master Oct 27, 2023
32 checks passed
@joeizang joeizang deleted the compiledetails-mainpanel-plugin branch October 27, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants