-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation details cleanup #4178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joeizang
force-pushed
the
compilation-details-cleanup
branch
from
October 31, 2023 13:49
e9d3840
to
1076215
Compare
Aniket-Engg
force-pushed
the
compilation-details-cleanup
branch
from
October 31, 2023 16:56
1b6ee00
to
060e346
Compare
Aniket-Engg
reviewed
Oct 31, 2023
@@ -114,7 +114,8 @@ export function isNative(name) { | |||
'injected', | |||
'doc-gen', | |||
'doc-viewer', | |||
'circuit-compiler' | |||
'circuit-compiler', | |||
'compliationDetails' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a typo in this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh!!! I will fix it now.
Aniket-Engg
approved these changes
Oct 31, 2023
joeizang
force-pushed
the
compilation-details-cleanup
branch
from
October 31, 2023 23:34
e7a283c
to
415b537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up wrong entries and remove wrongly placed files.