Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more info for invalid opcode #4183

Merged
merged 4 commits into from
Nov 1, 2023
Merged

add more info for invalid opcode #4183

merged 4 commits into from
Nov 1, 2023

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Nov 1, 2023

fixes #4079

and fixes #4071

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit ffe86cf
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/654246ad56b0150008f197db
😎 Deploy Preview https://deploy-preview-4183--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aniket-Engg Aniket-Engg added the ready-to-review PR ready to review label Nov 1, 2023
@@ -83,7 +83,7 @@ export function checkError (execResult, compiledContracts) {
const error = `Error occured: ${execResult.errorMessage}.\n`
let msg = ''
if (exceptionError === errorCode.INVALID_OPCODE) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my case, exceptionError was invalid opcode: PUSH0 so it didn't get in that "if". Is this possible to handle that case? just using includes might just do the trick.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Aniket-Engg Aniket-Engg merged commit 2491b71 into master Nov 1, 2023
32 checks passed
@Aniket-Engg Aniket-Engg deleted the invopc branch November 1, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
2 participants