support log transaction from iframe plugin #4245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm developing an iframe plugin for xinghuo bif, and I want to send a transaction log, and I got some issues.
Here is the first one.
Check the code here - https://github.com/ethereum/remix-project/blob/master/libs/remix-ui/terminal/src/lib/components/Context.tsx#L19
provider
will be missing if the transaction log is called from iframe plugin.Here is another one.
The decoded input does not convert correctly when it's BigNumber.
Here is the correct convert result.
BigNumber will turn to a ordinary object if it's passed through postMessage.
@Aniket-Engg @ryestew