call plugin using URL params after page load #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
callPlugin
branch
2 times, most recently
from
d680fb6
to
1699d1f
Compare
yann300
requested review from
ioedeveloper,
LianaHus,
Aniket-Engg and
ryestew
ioedeveloper
approved these changes
Sep 30, 2020
Aniket-Engg
reviewed
Sep 30, 2020
apps/remix-ide/src/app.js
Outdated
| await appManager.activatePlugin(workspace) | ||
| appManager.activatePlugin(workspace).then(() => { | ||
| // If plugins are loaded from the URL params, we focus on the last one. | ||
| if (pluginLoader.current === 'queryParams' && Array.isArray(workspace) && workspace.length > 0) menuicons.select(workspace[workspace.length - 1]) |
There was a problem hiding this comment.
Array.isArray(workspace) is already checked above with if
apps/remix-ide/src/app.js
Outdated
| @@ -405,7 +405,21 @@ Please make a backup of your contracts and start using http://remix.ethereum.org | |||
| // Set workspace after initial activation | |||
| if (Array.isArray(workspace)) { | |||
| try { | |||
There was a problem hiding this comment.
Not sure, if try-catch is still required as we don't have any await statement now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pluginCallcan be used as an url parameter to call a plugin after page loads.This will be mostly used now for loading a learneth tutorial from a link.