Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable contract pinning for VM #4646

Merged
merged 18 commits into from
Apr 5, 2024
Merged

enable contract pinning for VM #4646

merged 18 commits into from
Apr 5, 2024

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Mar 19, 2024

Allow to pin contract for VM environments

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit ee71053
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/660ecc5dd5bc9a0008e400cf
😎 Deploy Preview https://deploy-preview-4646--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LianaHus
Copy link
Collaborator

LianaHus commented Apr 4, 2024

pinned btn is still green instead of filled

@LianaHus
Copy link
Collaborator

LianaHus commented Apr 4, 2024

you need a bit more space after "Currently you have no pinned contracts to interact with.", also once you pin and unpit a contract you don't see that msg anymore. The other issue is that one and the one for unpinned have different styles. can't we make the similar? for example text-secondary or text-info.

@yann300
Copy link
Contributor

yann300 commented Apr 4, 2024

can we add (if it's not arleady there) a matomo check when one interact with a pinned instance.

@LianaHus
Copy link
Collaborator

LianaHus commented Apr 4, 2024

data-id deployAndRunClearInstances p-2
data-id NoPinnedInstanceText m-2
no item elements: alert alert-secondary

@Aniket-Engg
Copy link
Collaborator Author

secondary

done

@Aniket-Engg
Copy link
Collaborator Author

you need a bit more space after "Currently you have no pinned contracts to interact with.", also once you pin and unpit a contract you don't see that msg anymore. The other issue is that one and the one for unpinned have different styles. can't we make the similar? for example text-secondary or text-info.

done

@Aniket-Engg
Copy link
Collaborator Author

pinned btn is still green instead of filled

done

@Aniket-Engg
Copy link
Collaborator Author

can we add (if it's not arleady there) a matomo check when one interact with a pinned instance.

done

@LianaHus
Copy link
Collaborator

LianaHus commented Apr 5, 2024

with the way you log in matomo we can't filter by network. I would like to know why @yann300 want to add tracking and what exactly should be tracked.

@Aniket-Engg
Copy link
Collaborator Author

with the way you log in matomo we can't filter by network. I would like to know why @yann300 want to add tracking and what exactly should be tracked.

If purpose of adding matomo is to ensure that user interact with pinned contract, that is solved by matomo added in this PR.

There is already a matomo tracking which checks on which network contract is pinned

@Aniket-Engg Aniket-Engg merged commit 8ffd825 into master Apr 5, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the pinForVM branch April 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants