Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hometab updates #4774

Merged
merged 91 commits into from
Jun 14, 2024
Merged

Hometab updates #4774

merged 91 commits into from
Jun 14, 2024

Conversation

joeizang
Copy link
Collaborator

Update the hometab of IDE based on designs on excalidraw from @LianaHus

@joeizang joeizang added the WIP label Apr 30, 2024
@joeizang joeizang self-assigned this Apr 30, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit ec329d8
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/666c07bc567c7b00088f8ca4
😎 Deploy Preview https://deploy-preview-4774--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang force-pushed the hometab-update-001 branch 3 times, most recently from bd1504c to 0450224 Compare May 9, 2024 10:43
@joeizang joeizang force-pushed the hometab-update-001 branch 2 times, most recently from 6699e85 to 518cd5d Compare May 17, 2024 08:05
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels May 23, 2024
@joeizang joeizang marked this pull request as ready for review May 23, 2024 09:26
@LianaHus
Copy link
Collaborator

LianaHus commented May 29, 2024 •
edited by joeizang
Loading

  • New file should create a file in current workspace
  • some more spacing for title of File section (Exlpore...)
  • add space after recent section and remove from the top of it
  • slides should have more height
  • for the Connect to Local File system button
  • Alert alert-danger for alerts on the status bar and danger text color for icon and the text
  • Alert window height should be adjusted
  • align sections on status bar
  • increase a margin-bottom for toaster
  • If the workspace is not a github repo the text "not a git repo" can become a btn "init as git repo"
  • all status bar sections should have tooltips
  • for next iteration: Plugins from the selected list should be able to register a component/html el and a callback.
  • https should go to the new line (as discussed) in case of not enough space
  • Remix Copilo is red, why?
  • mouse should be pointer on 'Scam Alert'
  • images are shrinked sometimes on featured slides
  • Start coding has a tooltip saying one thing another functionality. For a quick fix you can have Create a Basic workspace but for the normal fix it should open a modal to choose from templates aka new plugin for templates.

@joeizang joeizang force-pushed the hometab-update-001 branch 5 times, most recently from 02d654f to 2e04cbb Compare June 3, 2024 18:22
ryestew
ryestew reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting PR!!
I do have some comments:
the visited link in the red is a bit dark:
image

This is a minor issue - so it can be merged as is.

A more important point is that because LearnEth is gone, there should be links to it from one of the scrolling boxes. This request is outside of this PR.

@vermouth22
Copy link
Collaborator

vermouth22 commented Jun 4, 2024 •
edited
Loading

Looks great! However one fundamental issue, take note the attached image is the res seen on a 13 inch Mac M1 laptop. This shows even less real estate than the existing IDE hometab.

  1. Something should be done on progressive resolution changes per machine. Or, a combination of moving things up. Like shortening the vertical dimension of the new "Featured" panel, etc. Also, where to click through to "LearnEth"?
  2. Tagline for Remix should say: "Learn. Explore. Create." because "Native IDE" we decided a while ago, has no meaning
  3. Links below tagline should be "Website Remix Desktop Documentation" ... In this iteration there are two links for Desktop
  4. Tagline below that (above Start Coding)... "Explore. Prototype. Create" should be removed
  5. "Recent workspaces", should be rendered in U/L so it should read "Recent Workspaces"
  6. "Connect to local filesystem" should also be U/L so it should read "Connect to Local Filesystem"
image

@ryestew
Copy link
Collaborator

ryestew commented Jun 14, 2024

The link for remix desktop should be updated to this one:
https://github.com/remix-project-org/remix-desktop-insiders

@joeizang joeizang merged commit 60a21f8 into master Jun 14, 2024
32 checks passed
@joeizang joeizang deleted the hometab-update-001 branch June 14, 2024 21:48
LianaHus
LianaHus reviewed Jun 18, 2024
View reviewed changes
apps/remix-ide/src/app/components/preload.tsx
@@ -31,8 +31,10 @@ export const Preload = (props: any) => {
)

function loadAppComponent() {
console.log('loading remix in the preloader')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is removed in #4897

LianaHus
LianaHus reviewed Jun 18, 2024
View reviewed changes
apps/remix-ide/src/app/components/preload.tsx
@@ -68,6 +70,7 @@ export const Preload = (props: any) => {
if (fsLoaded) {
console.log(fsLoaded.name + ' activated')
_paq.push(['trackEvent', 'Storage', 'activate', fsLoaded.name])
console.log('loading remix in the preloader')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is removed in #4897

LianaHus
LianaHus reviewed Jun 18, 2024
View reviewed changes
apps/remix-ide/src/app/components/preload.tsx
import('../../app')
.then((AppComponent) => {
console.log('loading remix in the preloader', AppComponent)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is removed in #4897

LianaHus
LianaHus reviewed Jun 18, 2024
View reviewed changes
libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx
handleHide={() => hideFullMessage()}
okFn={() => processLoading(state.modalInfo.title)}
>
<ModalDialog id="homeTab" title={'Import from ' + state.modalInfo.title} okLabel="Import" hide={!state.showModalDialog} handleHide={() => hideFullMessage()} okFn={() => processLoading(state.modalInfo.title)}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is too long to be a 1 line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

LianaHus
LianaHus reviewed Jun 18, 2024
View reviewed changes
libs/remix-ui/home-tab/src/lib/components/homeTabFile.tsx
<label style={{ fontSize: '0.8rem' }} className="mt-3">
Recent workspaces
Recent Workspaces
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the tab

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LianaHus LianaHus LianaHus left review comments

@ryestew ryestew ryestew approved these changes

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

Assignees

@joeizang joeizang

Labels
ready-to-review PR ready to review translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joeizang @LianaHus @vermouth22 @ryestew @Aniket-Engg