Dgituifix #5007
Merged
Dgituifix #5007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bunsenstraat
commented
Jul 16, 2024
•
bunsenstraat
commented
- the header was a bit broken, things would not line up and not be truncated correctly. I simplified in agreement with Liana
- the detached head warning wasn't displayed because it was on 1 line with the message
- I added required px-2 to the whole plugin
- some buttons where renamed
- I widen the plugin just like debugger to make more space to read
- somehow dgitApi wasn't activated in app.js anymore... don't know how that happened
- needed to add some pauses to the e2e because the animation causes rerendering which causes elements to be not clickable
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.