Templates 2 #5022
Merged
Templates 2 #5022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
force-pushed
the
templates_2
branch
2 times, most recently
from
661b5ca
to
f65c0d7
Compare
Aniket-Engg
reviewed
Jul 18, 2024
| pinned={this.pinnedProviders.includes(provider.name)} | ||
| pinStateCallback={async (pinned: boolean) => { | ||
| if (pinned) { | ||
| this.emit('providerPinned', provider.name, provider) | ||
| this.call('notification', 'toast', `"${provider.displayName}" has been added to the Network list of the Deploy & Run Transactions module.`) |
There was a problem hiding this comment.
It should be 'added to the Network Environment list of the Deploy & Run Transactions module plugin'
| return true | ||
| } | ||
| const providerName = await this.call('blockchain', 'getProvider') | ||
| if (providerName !== provider.name) { | ||
| this.emit('providerUnpinned', provider.name, provider) | ||
| this.call('notification', 'toast', `"${provider.displayName}" has been removed from the Network list of the Deploy & Run Transactions module.`) |
| pinned={this.pinnedProviders.includes(provider.name)} | ||
| pinStateCallback={async (pinned: boolean) => { | ||
| if (pinned) { | ||
| this.emit('providerPinned', provider.name, provider) | ||
| this.call('notification', 'toast', `"${provider.displayName}" has been added to the Network list of the Deploy & Run Transactions module.`) |
| return true | ||
| } | ||
| const providerName = await this.call('blockchain', 'getProvider') | ||
| if (providerName !== provider.name) { | ||
| this.emit('providerUnpinned', provider.name, provider) | ||
| this.call('notification', 'toast', `"${provider.displayName}" has been removed from the Network list of the Deploy & Run Transactions module.`) |
| classList='EECellStyle' | ||
| pinned={this.pinnedProviders.includes(provider.name)} | ||
| pinStateCallback={async (pinned: boolean) => { | ||
| if (pinned) { | ||
| this.emit('providerPinned', provider.name, provider) | ||
| this.call('notification', 'toast', `"${provider.displayName}" has been added to the Network list of the Deploy & Run Transactions module.`) |
There was a problem hiding this comment.
here and everywhere similarly
| @@ -129,13 +129,60 @@ export class RunTab extends ViewPlugin { | |||
| async onInitDone() { | |||
| const udapp = this // eslint-disable-line | |||
|
|
|||
| const descriptions = { | |||
| 'vm-cancun': 'Deploy to an in-browser virtual machine which run the cancun fork.', | |||
There was a problem hiding this comment.
Names should be capitalized like Cancun
| @@ -129,13 +129,60 @@ export class RunTab extends ViewPlugin { | |||
| async onInitDone() { | |||
| const udapp = this // eslint-disable-line | |||
|
|
|||
| const descriptions = { | |||
| 'vm-cancun': 'Deploy to an in-browser virtual machine which run the cancun fork.', | |||
| 'vm-shanghai': 'Deploy to an in-browser virtual machine which run the cancun fork.', | |||
There was a problem hiding this comment.
here and similarly everywhere
| 'vm-paris': 'Deploy to an in-browser virtual machine which run the paris fork.', | ||
| 'vm-london': 'Deploy to an in-browser virtual machine which run the london fork.', | ||
| 'vm-berlin': 'Deploy to an in-browser virtual machine which run the berlin fork.', | ||
| 'vm-mainnet-fork': 'Deploy to an in-browser virtual machine which fork locally the ethereum mainnet.', |
| 'vm-custom-fork': 'Deploy to an in-browser virtual machine which fork locally a custom network.', | ||
| 'walletconnect': 'Deploy using wallet connect.', | ||
| 'basic-http-provider': 'Deploy to a custom local network.', | ||
| 'hardhat-provider': 'Deploy to a hardhat development nework.', |
There was a problem hiding this comment.
Hardhat with capital H, and similarly
| const addProvider = async (position, name, displayName, isInjected, isVM, fork = '', dataId = '', title = '') => { | ||
| console.log(name) |
Aniket-Engg
reviewed
Jul 18, 2024
ryestew
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the grid view and the env providers view: