Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remixd test #5102

Merged
merged 22 commits into from
Aug 22, 2024
Merged

fix remixd test #5102

merged 22 commits into from
Aug 22, 2024

Conversation

bunsenstraat
Copy link
Collaborator

@bunsenstraat bunsenstraat commented Aug 21, 2024

  • when renamepath runs and one of the steps fails done() is never called this causes nightwatch to wait for a timeout after 10 minutes stalling the CI job
  • same applies to spawnremixd, when it fails the script should end
  • when the test fails the remixd files have changed, so a rerun of the test would fail too because the test files the test uses are changed and not found causing the test to always fail. so resetting head after running is necessary

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 68ebd5e
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66c630b335671600089e6deb
😎 Deploy Preview https://deploy-preview-5102--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bunsenstraat bunsenstraat marked this pull request as draft August 21, 2024 16:33
@bunsenstraat bunsenstraat changed the title Failtestfaster fix remid test Aug 21, 2024
@bunsenstraat bunsenstraat marked this pull request as ready for review August 21, 2024 18:24
@bunsenstraat bunsenstraat changed the title fix remid test fix remixd test Aug 21, 2024
@bunsenstraat bunsenstraat merged commit c987302 into master Aug 22, 2024
32 checks passed
@bunsenstraat bunsenstraat deleted the failtestfaster branch August 22, 2024 06:50
@Aniket-Engg Aniket-Engg added the browser-tests e2e tests for remix-ide label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-tests e2e tests for remix-ide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants