Use remix plugin 0.3 #511
Merged
Use remix plugin 0.3 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/remix-ide/package.json
Outdated
| @@ -80,7 +80,7 @@ | |||
| "yo-yoify": "^3.7.3" | |||
| }, | |||
| "dependencies": { | |||
| "@remixproject/engine": "^0.2.5", | |||
| "@remixproject/engine-web": "^0.2.5", | |||
yann300
force-pushed
the
remixplugin0.3
branch
from
273560c
to
cb35ede
Compare
yann300
force-pushed
the
remixplugin0.3
branch
3 times, most recently
from
9606207
to
e8c9989
Compare
yann300
force-pushed
the
remixplugin0.3
branch
9 times, most recently
from
568b653
to
f16c126
Compare
yann300
force-pushed
the
remixplugin0.3
branch
from
30a92a6
to
51576ba
Compare
GrandSchtroumpf
approved these changes
Nov 16, 2020
| @@ -2,7 +2,8 @@ const yo = require('yo-yo') | |||
| const csjs = require('csjs-inject') | |||
| const EventEmitter = require('events') | |||
| const LocalPlugin = require('./local-plugin') | |||
| import { ViewPlugin, IframePlugin, WebsocketPlugin } from '@remixproject/engine' | |||
| import { IframePlugin, WebsocketPlugin } from '@remixproject/engine-web' | |||
| import { ViewPlugin } from '@remixproject/engine' | |||
There was a problem hiding this comment.
In 0.3.3 this should come from engine-web too
| @@ -61,7 +61,7 @@ class DebuggerTab extends ViewPlugin { | |||
|
|
|||
| this.renderComponent() | |||
|
|
|||
| this.call('manager', 'activatePlugin', 'source-verification').catch(e => console.log(e.message)) | |||
| // this.call('manager', 'activatePlugin', 'source-verification').catch(e => console.error(e)) | |||
| async canActivate (from, to) { | ||
| return canActivate(from.name) | ||
| async canActivatePlugin (from, to) { | ||
| return true // canActivate(from.name) |
There was a problem hiding this comment.
any plugin can activate another ?
| } | ||
|
|
||
| async canDeactivate (from, to) { | ||
| async canDeactivatePlugin (from, to) { | ||
| console.log('canDeactivatePlugin', from, to) |
There was a problem hiding this comment.
Maybe remove console.log
| onRegistration (plugin) { | ||
| this.event.emit('added', plugin.name) | ||
| onRegistration () { | ||
| console.log('manager has been registered') |
| }) | ||
| return plugins.map(plugin => { | ||
| if (plugin.name === 'scriptRunner') { | ||
| plugin.url = 'ipfs://QmRWBCgCzKa1ixoVN9mvJACVuqWLRTRYS4sUJ9wzUBRHSf' |
There was a problem hiding this comment.
Why not setting it directly in the profile above ?
libs/remixd/package.json
Outdated
| "@remixproject/plugin-api": "0.3.0-beta.5", | ||
| "@remixproject/plugin-utils": "0.3.0-beta.5", | ||
| "@remixproject/plugin-ws": "^0.3.0-beta.8", | ||
| "@remixproject/plugin": "^0.3.2", |
yann300
force-pushed
the
remixplugin0.3
branch
2 times, most recently
from
a8bef89
to
79efc01
Compare
yann300
force-pushed
the
remixplugin0.3
branch
from
6c91dcc
to
76818ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.