Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update web3.js import #5160

Merged
merged 2 commits into from
Sep 10, 2024
Merged

update web3.js import #5160

merged 2 commits into from
Sep 10, 2024

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Sep 3, 2024

fix #4610

@yann300 yann300 added the ready-to-review PR ready to review label Sep 3, 2024
Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit e749daf
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66e05a248c34f40008b5bb22
😎 Deploy Preview https://deploy-preview-5160--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 force-pushed the update_web3.js branch 2 times, most recently from cec04be to d58a5b5 Compare September 3, 2024 11:05
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change set looks fine but e2e are failing

@Aniket-Engg
Copy link
Collaborator

Aniket-Engg commented Sep 10, 2024

FYI @yann300 changing the import for web3 fails to execute the script. May be we need to first update the web3 version in script runner side https://github.com/remix-project-org/script-runner/blob/master/package.json#L51 So i have reverted those changes as of now, that can come in other PR

@Aniket-Engg Aniket-Engg merged commit 4ed2409 into master Sep 10, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the update_web3.js branch September 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade web3.js v1 to v4
2 participants