-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hometab: Learneth slider & Learneth promo #5166
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please change the image before merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix e2e's and the pr is golden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to include list.json
you can run
git checkout master -- apps/remix-ide/src/assets/list.json
then add the change commit push
The image could be a lot larger... like it is for Beta Tester panel. Also, the cursor is still showing on rollover of "Start Learning" button instead of a pointer |
d1b5d4d
to
c3c3833
Compare
list.json removed |
Image looks quite similar to one in beta tester panel. I update the cursor to pointer too |
The code needs to be organized better. The cursor needs to be an pointer in the slider.