Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hometab: Learneth slider & Learneth promo #5166

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Hometab: Learneth slider & Learneth promo #5166

merged 7 commits into from
Sep 12, 2024

Conversation

ryestew
Copy link
Collaborator

@ryestew ryestew commented Sep 7, 2024

The code needs to be organized better. The cursor needs to be an pointer in the slider.

Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 727319a
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66e2a19ac056290008eed4b8
😎 Deploy Preview https://deploy-preview-5166--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryestew ryestew changed the title Learneth sl Hometab: Learneth slider & Learneth promo Sep 9, 2024
@LianaHus
Copy link
Collaborator

Please change the image before merge

Copy link
Collaborator

@joeizang joeizang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix e2e's and the pr is golden.

@joeizang joeizang self-requested a review September 11, 2024 13:51
Copy link
Collaborator

@bunsenstraat bunsenstraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to include list.json
you can run
git checkout master -- apps/remix-ide/src/assets/list.json
then add the change commit push

@vermouth22
Copy link
Collaborator

The image could be a lot larger... like it is for Beta Tester panel. Also, the cursor is still showing on rollover of "Start Learning" button instead of a pointer

@Aniket-Engg
Copy link
Collaborator

no need to include list.json you can run git checkout master -- apps/remix-ide/src/assets/list.json then add the change commit push

list.json removed

@Aniket-Engg
Copy link
Collaborator

The image could be a lot larger... like it is for Beta Tester panel. Also, the cursor is still showing on rollover of "Start Learning" button instead of a pointer

Image looks quite similar to one in beta tester panel. I update the cursor to pointer too

@Aniket-Engg Aniket-Engg merged commit 2502807 into master Sep 12, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the learnethSl branch September 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants