-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File explorer #668
File explorer #668
Conversation
72eee3b
to
df0dd40
Compare
731cc70
to
086572e
Compare
297f570
to
c75c802
Compare
When I try to connect with remixd, with the absolute path to a folder, in the file explorer, I get the localhost folder at the root of my computer. |
So its probably beyond the scope of what you are doing for this 1st move to React - but it would be nice if a user could drag a file into and out of a folder. Its a currently a bit hard to clean up the folders & files ( in master and in this branch). |
Creating a file and folder in localhost is great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c2e5eb2
to
f92865c
Compare
I also experienced this bug after I rebased to master. It is somehow related to @yann300 PR https://github.com/ethereum/remix-project/pull/689/files. |
self._deps.fileProviders.localhost.event.register('connected', (event) => { | ||
fileSystemExplorer.show() | ||
}) | ||
// this._deps.fileProviders.localhost.event.register('connected', (event) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is handled somewhere else or you don't want anymore these event to apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are still valid events. I will update my PR.
87b22e0
to
e001bfb
Compare
If I right click on the icons, not on the names, I don't get a context menu, is that by design? |
Yes it is. I had trouble retreiving filename if icon is clicked so I limited it to the text field. |
No description provided.