Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File explorer #668

Merged
merged 91 commits into from
Jan 18, 2021
Merged

File explorer #668

merged 91 commits into from
Jan 18, 2021

Conversation

ioedeveloper
Copy link
Member

No description provided.

@ryestew
Copy link
Collaborator

ryestew commented Jan 15, 2021

When I try to connect with remixd, with the absolute path to a folder, in the file explorer, I get the localhost folder at the root of my computer.

@ryestew
Copy link
Collaborator

ryestew commented Jan 15, 2021

the 4th icon -
image
is confusing me - I think the text instead of:
Upload Local files to the Browser Storage Explorer

should be:
Load a local file into Remix's browser folder

@ryestew
Copy link
Collaborator

ryestew commented Jan 15, 2021

So its probably beyond the scope of what you are doing for this 1st move to React - but it would be nice if a user could drag a file into and out of a folder. Its a currently a bit hard to clean up the folders & files ( in master and in this branch).

@ryestew
Copy link
Collaborator

ryestew commented Jan 15, 2021

Creating a file and folder in localhost is great!

Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder icons are too dark in the light theme. I put filter: invert(0.5); and it looks like this now:

image

and in the dark theme its not as essential. You have:

image

and with the filter its:
image

@ioedeveloper
Copy link
Member Author

When I try to connect with remixd, with the absolute path to a folder, in the file explorer, I get the localhost folder at the root of my computer.

I also experienced this bug after I rebased to master. It is somehow related to @yann300 PR https://github.com/ethereum/remix-project/pull/689/files.

self._deps.fileProviders.localhost.event.register('connected', (event) => {
fileSystemExplorer.show()
})
// this._deps.fileProviders.localhost.event.register('connected', (event) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handled somewhere else or you don't want anymore these event to apply?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are still valid events. I will update my PR.

@bunsenstraat
Copy link
Collaborator

If I right click on the icons, not on the names, I don't get a context menu, is that by design?

@yann300 yann300 self-requested a review January 18, 2021 13:02
@ioedeveloper
Copy link
Member Author

If I right click on the icons, not on the names, I don't get a context menu, is that by design?

Yes it is. I had trouble retreiving filename if icon is clicked so I limited it to the text field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants