-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom compiler context for remix-tests CLI #741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aniket-Engg
force-pushed
the
remixTestsCompilerContext
branch
from
January 19, 2021 11:18
2d751a5
to
c211ea4
Compare
yann300
reviewed
Jan 19, 2021
@@ -37,7 +37,7 @@ | |||
"dependencies": { | |||
"@remix-project/remix-lib": "^0.4.31", | |||
"@remix-project/remix-simulator": "^0.1.9-beta.8", | |||
"@remix-project/remix-solidity": "^0.3.32", | |||
"@remix-project/remix-solidity": "file:../remix-solidity", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this need to be rollbacked i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, to get this PR working fine this was required. This will be rollbacked during the release process
yann300
previously approved these changes
Jan 19, 2021
Adds an optimize flag to the commander CLI config which generates a CompilerConfiguration object and passes it down the line to the compiler optionally.
Aniket-Engg
force-pushed
the
remixTestsCompilerContext
branch
from
January 19, 2021 13:38
6586e05
to
ae30454
Compare
yann300
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #540
continued from #563