Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve annotations #876

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Improve annotations #876

merged 2 commits into from
Feb 16, 2021

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Feb 15, 2021

fix #687
fix #787

Copy link
Collaborator

@bunsenstraat bunsenstraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it with testing plugins to see if annotation stay when switching between plugins and tab. clearing annotations also works fine. anything else I need to test @yann300 ?

@yann300
Copy link
Contributor Author

yann300 commented Feb 16, 2021

clearing annotations also works fine. anything else I need to test

making sure decoration are removed when the plugin is deactivated, but I think you already did.

@yann300 yann300 merged commit fd60c27 into master Feb 16, 2021
@yann300 yann300 deleted the ImproveAnnotation branch February 16, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants