Display icons based on file types. #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioedeveloper
requested review from
bunsenstraat,
ryestew,
yann300,
LianaHus and
Aniket-Engg
ioedeveloper
force-pushed
the
FE-icons
branch
from
8ceb1ad
to
21f0f67
Compare
yann300
reviewed
Feb 18, 2021
| find: find | ||
| find: find, | ||
| getPathIcon (path) { | ||
| return path.endsWith('.txt') |
There was a problem hiding this comment.
that would be perhaps more readable with a switch case
There was a problem hiding this comment.
A switch statement will not work so well for path.endsWith() because the argument for switch will need to match a case, which we don't have in this case.
yann300
approved these changes
Feb 18, 2021
Aniket-Engg
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198