Add --reuse-hashes option to update script #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
force-pushed
the
make-update-script-create-wasm-symlinks
branch
from
c487c04 to
a6aff48
Compare
…sier - generateLegacyListJS() moved to the top not to obscure the part of the script that's outside of any functions. - readFile() and buildVersion() Moved out of processDir() because makeEntry() uses them. - The code for generating entries on the list extracted into makeEntry(). I'm going to make it longer and keeping it inside a map() call hurts readability.
…culation when list.json already exists
chriseth
force-pushed
the
update-script-reuse-hashes
branch
from
c22e150 to
68b1834
Compare
chriseth
changed the base branch from
make-update-script-create-wasm-symlinks
to
gh-pages
|
Rebased. |
chriseth
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ethereum/solidity#9258. The PR is based on #49 but only for convenience - both modify
processDir()function and would conflict otherwise.You can now run
./update --reuse-hashesand have the script finish almost immediately iflist.jsonfiles already exist.Note that the
updatescript usually truncates the lists just after it starts and only then all the heavy processing happens. That's probably due to lazy evaluation ofparsedList. This means that if you interrupt it or if it fails for some reason, you should revert the lists usinggitor it will have to recalculate all hashes anyway.