Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM version: "petersburg" #6086

Closed
axic opened this issue Feb 25, 2019 · 1 comment
Closed

EVM version: "petersburg" #6086

axic opened this issue Feb 25, 2019 · 1 comment

Comments

@axic
Copy link
Member

axic commented Feb 25, 2019

Constantinople was launched on the testnets, but was cancelled last minute on mainnet. It is to be launched on the same block as "Petersburg", which disables "net gas metering" introduced in Constantinople.

Since we do not support net gas metering in the gas estimator this should have no effect for us.

While it feels strange to have two hard forks, which in practice mean a single one, I still suggest we introduced "petersburg" as an entry in our EVMVersion listed to avoid any further confusion with users.

It is not fully clear if the community will refer to this hardfork as "constantinople" or "petersburg", but technically all documentation and clients are referring to it separately.

@axic
Copy link
Member Author

axic commented Feb 28, 2019

The metadata EIP refers to it as "Petersburg" just as geth and truffle do.

Just for the reason Truffle as a popular devtool uses the term "Petersburg" I think we should do as well to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant