Support petersburg in evmVersion #6144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
reviewed
Feb 28, 2019
chriseth
reviewed
Feb 28, 2019
chriseth
reviewed
Feb 28, 2019
chriseth
reviewed
Feb 28, 2019
chriseth
reviewed
Feb 28, 2019
|
Need to also include documentation. |
Codecov Report
@@ Coverage Diff @@
## develop #6144 +/- ##
===========================================
- Coverage 87.92% 87.91% -0.02%
===========================================
Files 375 374 -1
Lines 35978 35776 -202
Branches 4257 4221 -36
===========================================
- Hits 31633 31451 -182
+ Misses 2910 2901 -9
+ Partials 1435 1424 -11
|
|
Taking this over. |
Lets merge #5959 first, I can finish this after. |
|
Not sure what to document, but I think this is fine to merge. |
|
#5959 is ready for final review. |
|
@axic not that this all has to happen in the next 3-4 hours. |
|
Missing a change in CommandlineInterface.cpp. |
Isnt release tomorrow and not today? |
|
Yes, it is tomorrow, so the code has to be finished today, also to have a nightly binary that can be tested in remix. |
|
Even if there's no conflict I'd rebase this due to the optimiser changes. |
axic
commented
Mar 4, 2019
axic
commented
Mar 4, 2019
|
Rebased and updated commandline compiler. |
|
Updated. |
|
Looks good, cannot approve myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6086.
Ref: https://blog.ethereum.org/2019/02/22/ethereum-constantinople-st-petersburg-upgrade-announcement/