Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename asm json import command-line tests #14866

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

aarlt
Copy link
Member

@aarlt aarlt commented Feb 18, 2024

@nikola-matic
Copy link
Collaborator

@aarlt can you fetch fresh develop and rebase - the fix for win_pyscripts went in last week I believe.

@aarlt aarlt force-pushed the rename_tests_asm_json_import_to_import_asm_json branch from 8348a6a to e78f342 Compare February 20, 2024 11:02
@nikola-matic nikola-matic force-pushed the rename_tests_asm_json_import_to_import_asm_json branch from e78f342 to 678df12 Compare February 23, 2024 13:35
nikola-matic
nikola-matic previously approved these changes Feb 23, 2024
@nikola-matic
Copy link
Collaborator

@aarlt feel free to merge if there's no dependencies.

@ekpyron
Copy link
Member

ekpyron commented Mar 4, 2024

Too late for merging - now it needs a rebase or sth :-). It does pay of to just merge "clearly harmless" stuff like this right with approving, resp. setting it to auto-merge (don't overdo that, but just test-renaming is safe-enough...)

Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Mar 21, 2024
@GAMECHANGE

This comment was marked as spam.

GAMECHANGE

This comment was marked as spam.

@github-actions github-actions bot removed the stale The issue/PR was marked as stale because it has been open for too long. label Mar 22, 2024
@cameel
Copy link
Member

cameel commented Apr 4, 2024

If you're renaming these tests it would probably make sense to also rename the standard_import_evmasm_... ones to standard_import_asm_json_... since they're testing the same feature, just via Standard JSON.

@aarlt aarlt force-pushed the rename_tests_asm_json_import_to_import_asm_json branch from 678df12 to c5c0bc5 Compare April 8, 2024 09:22
@aarlt aarlt requested a review from nikola-matic April 8, 2024 09:55
@cameel cameel merged commit 2bc657a into develop Apr 8, 2024
73 checks passed
@cameel cameel deleted the rename_tests_asm_json_import_to_import_asm_json branch April 8, 2024 14:39
@cameel cameel changed the title Rename some tests. Rename asm json import command-line tests Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants