Add missing ASAN runtime libraries #15454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
cameel
previously approved these changes
Sep 25, 2024
|
But you should test it by temporarily moving nighty jobs to the PR workflow. |
r0qs
force-pushed
the
add-missing-asan-rt-libraries
branch
from
85642a1
to
bebbc4e
Compare
r0qs
force-pushed
the
add-missing-asan-rt-libraries
branch
from
bebbc4e
to
3d738c7
Compare
|
|
You can see a test here: https://app.circleci.com/pipelines/github/ethereum/solidity/36134/workflows/eb89e05e-50b3-4782-8a1a-566d6eef156b |
r0qs
force-pushed
the
add-missing-asan-rt-libraries
branch
from
3d738c7
to
cffc4f8
Compare
cameel
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package libclang-rt-dev which contains the sanitizer runtimes is missing in our ubuntu 24.04 clang image, causing problems like: https://app.circleci.com/pipelines/github/ethereum/solidity/36095/workflows/642d1bc0-2c10-48d8-a8c3-0c6812a177cf/jobs/1644834
After installing the runtime libraries, I was able to successfully build the image locally.