Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prater Testnet Support #189

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Prater Testnet Support #189

merged 2 commits into from
Mar 22, 2021

Conversation

CarlBeek
Copy link
Collaborator

Adds support for the new Prater Testnet.

@CarlBeek CarlBeek added documentation Improvements or additions to documentation release labels Mar 19, 2021
@CarlBeek CarlBeek requested a review from hwwhww March 19, 2021 12:13
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about removing dead testnets: WITTI, ALTONA, MEDALLA, SPADINA, ZINKEN?

@CarlBeek
Copy link
Collaborator Author

I was thinking of leaving those options in so as to allow people to recover thier old keys should they ever want to. That said, I can't think of a genuine reason why anyone would want to do so and they can always go back in the release/tag/commit history.

I will remove the dead testnets, but I will also make sure it is noted in the release notes.

@CarlBeek CarlBeek merged commit 32c60c0 into dev Mar 22, 2021
@CarlBeek CarlBeek deleted the prater_testnet branch March 22, 2021 14:37
@CarlBeek CarlBeek mentioned this pull request Mar 22, 2021
CarlBeek added a commit that referenced this pull request Mar 22, 2021
## Release v1.1.1:

* Ensure keystore permissions are 440 #176
* Adds Prater testnet support #189
* Removes support for old testnets (Witti, Altona, Medalla, Spadina, Zinken) #189
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
* Adds Prater Testnet Support
* Removes support for old testnets (Witti, Altona, Medalla, Spadina, Zinken)
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
## Release v1.1.1:

* Ensure keystore permissions are 440 ethereum#176
* Adds Prater testnet support ethereum#189
* Removes support for old testnets (Witti, Altona, Medalla, Spadina, Zinken) ethereum#189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants