Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Add GitPOAP Badge to Display Number of Minted GitPOAPs for Contributors #271

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

burz
Copy link
Contributor

@burz burz commented Jul 14, 2022

Hey all, this PR adds a GitPOAP Badge to the README that displays the number of minted GitPOAPs for this repository by contributors to this repo.

You can see an example of this in our Documentation repository.

This should help would-be contributors as well as existing contributors find out that they will/have received GitPOAPs for their contributions.

CC: @colfax23 @kayla-henrie

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarlBeek Fyi, this same feature was added to the ethereum.org repo as well for reference:
ethereum/ethereum-org-website#7025

@hwwhww hwwhww changed the base branch from master to dev July 28, 2022 09:32
@hwwhww hwwhww changed the base branch from dev to master July 28, 2022 09:32
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @burz, could you rebase this PR to based on the dev branch? Thanks!

@burz burz changed the base branch from master to dev July 28, 2022 11:50
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CarlBeek CarlBeek merged commit f482f1b into ethereum:dev Jul 31, 2022
everhusk pushed a commit to earthwallet/earth-wallet-cli that referenced this pull request Aug 3, 2023
[README] Add GitPOAP Badge to Display Number of Minted GitPOAPs for Contributors
Copy link

@Romek-cloud Romek-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Romek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants