Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await TTD notice added for MergeReadiness [Fixes #511] #514

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jun 27, 2022

Description

  • Updates design of /merge-readiness page to include notices about waiting on certain tasks until the TTD has been announced and included in client updates.
  • Design changes include dimming of the two tasks that should not yet be performed and disabling the checklist buttons.
  • Adds "timing" note to the task cards

Related issue

Preview link

https://deploy-preview-514--serene-carson-3331d5.netlify.app/en/merge-readiness

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samajammin samajammin merged commit ce5a2cc into dev Jun 27, 2022
@samajammin samajammin deleted the wait-for-ttd branch June 27, 2022 18:32
@nloureiro
Copy link

Screen Shot 2022-06-27 08 07 29 PM

Overall looks good!

Minor changes on the top squares.

  • remove the green from the grey-out ones.
  • time in bold
  • align-items:start to align to the top of the squares.

other than that I don't see any blockers

@nloureiro
Copy link

sticky.mov

one nice to have: what do you think of having the headings sticky? helps me to know in what section I am when reading it more slowly. keep track.

then again, nice to have :)

This was referenced Jun 30, 2022
@wackerow wackerow mentioned this pull request Oct 5, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants