Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Transaction Tests #374

Merged
merged 4 commits into from
Dec 8, 2017
Merged

General Transaction Tests #374

merged 4 commits into from
Dec 8, 2017

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Dec 4, 2017

No description provided.

@pirapira
Copy link
Member

pirapira commented Dec 4, 2017

Did Travis in cpp-ethereum already try the new tests?

@winsvega
Copy link
Collaborator Author

winsvega commented Dec 4, 2017

yes

@winsvega
Copy link
Collaborator Author

winsvega commented Dec 4, 2017

its this one ethereum/aleth#4664

@pirapira
Copy link
Member

pirapira commented Dec 4, 2017

Why are 10k lines removed while only 8k are added?

@pirapira pirapira closed this Dec 4, 2017
@pirapira pirapira reopened this Dec 4, 2017
@winsvega
Copy link
Collaborator Author

winsvega commented Dec 4, 2017

I've removed unneeded copies of the tests. a general test describe filler once and then the final test has results on each fork

before I had to copy each test case for new fork. now all testcases are executed on all forks by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants