Log detailed gossip results from bridge processes. #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
bridge-gossip-reporting
branch
from
2016e0b to
9ed3bbb
Compare
KolbyML
approved these changes
Oct 27, 2023
looks good. Having 3 trace logs for each seems like a lot, but I see were it is coming from.
portal-bridge/src/stats.rs
Outdated
Comment on lines
302
to
323
| let enr = Enr::from_str(enr).expect(""); | ||
| // don't double count an enr if multiple clients offered the same content | ||
| // to a peer | ||
| if !content_stats.offered.contains(&enr) { | ||
| content_stats.offered.push(enr); | ||
| } | ||
| } | ||
|
|
||
| for enr in info.accepted.iter() { | ||
| let enr = Enr::from_str(enr).expect(""); | ||
| if !content_stats.accepted.contains(&enr) { | ||
| content_stats.accepted.push(enr); | ||
| } | ||
| } | ||
|
|
||
| for enr in info.transferred.iter() { | ||
| let enr = Enr::from_str(enr).expect(""); | ||
| if !content_stats.transferred.contains(&enr) { | ||
| content_stats.transferred.push(enr); |
There was a problem hiding this comment.
These expect("") should never fail. But currently they are being used as if they were unwrap(). It would be nice to put a message saying x is impossible instead of an empty string. Just a nitpick so not a big deal if you don't want to, empty expect() just taste wrong idk. Just if the 1 in a billion chance happened we can just cntr f the text in the panic and find here quickly.
njgheorghita
force-pushed
the
bridge-gossip-reporting
branch
from
d608081 to
9834940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Updated the bridge gossip stats to accurately reflect what was gossiped, using the new trace gossip result type. The idea is to make grepping through the bridge logs a feasible way to figure out whether content was successfully gossiped into the network.
How was it fixed?
To-Do