refactor: update Gossip to PutContent
#1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
force-pushed
the
rename-gossip
branch
from
218db7a to
58a515a
Compare
KolbyML
force-pushed
the
rename-gossip
branch
from
58a515a to
2c7467e
Compare
ogenev
approved these changes
Dec 16, 2024
ethportal-api/src/types/portal.rs
Outdated
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct TraceGossipInfo { | ||
| pub struct PutContentInfo { | ||
| // Indicates how many peers the content was gossiped to |
There was a problem hiding this comment.
nit: Those comments should be doc strings:
Suggested change
| // Indicates how many peers the content was gossiped to | |
| /// Indicates how many peers the content was gossiped to |
| @@ -114,21 +115,21 @@ pub trait BeaconNetworkApi { | |||
|
|
|||
| /// Send the provided content value to interested peers. Clients may choose to send to some or | |||
| /// all peers. Return the number of peers that the content was gossiped to. | |||
There was a problem hiding this comment.
nit: We have changed the return format, and those doc strings should be updated here and in history and state files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
the spec changed ethereum/portal-network-specs#346
How was it fixed?
update
portal_*Gossiptoportal_*PutContent