Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move crate utp-testing to testing/utp #1631

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Jan 13, 2025

What was wrong?

testing crates should be in the testing folder. I said I was going to make this PR here #1624 and #1621

How was it fixed?

moving the crate

@KolbyML KolbyML self-assigned this Jan 13, 2025
@ogenev
Copy link
Member

ogenev commented Jan 14, 2025

testing/utp-testing seems a little redundant here, what do others think about renaming this to testing/utp?

@KolbyML
Copy link
Member Author

KolbyML commented Jan 14, 2025

testing/utp-testing seems a little redundant here, what do others think about renaming this to testing/utp?

sure I will update the PR

@KolbyML KolbyML force-pushed the move-utp-testing branch 3 times, most recently from c7e37fe to d468f34 Compare January 14, 2025 13:50
@KolbyML KolbyML changed the title refactor: move crate utp-testing to testing/utp-testing refactor: move crate utp-testing to testing/utp Jan 14, 2025
@KolbyML
Copy link
Member Author

KolbyML commented Jan 14, 2025

testing/utp-testing seems a little redundant here, what do others think about renaming this to testing/utp?

ready for another review

Copy link
Collaborator

@njgheorghita njgheorghita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KolbyML KolbyML merged commit 2a481d3 into ethereum:master Jan 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants