This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Hashablification #1394
Merged
Hashablification #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannikluhn
force-pushed
the
hashable-ssz-tests
branch
2 times, most recently
from
21dc89a to
4c9231b
Compare
jannikluhn
force-pushed
the
hashable-ssz-tests
branch
10 times, most recently
from
4d78c8e to
84fb90d
Compare
hwwhww
approved these changes
Dec 17, 2019
| state.balances, index, lambda balance, *_: Gwei(balance + delta) | ||
| ) | ||
| ) | ||
| return state.transform(("balances", index), lambda balance: Gwei(balance + delta)) |
| @@ -473,7 +483,7 @@ def _determine_next_eth1_votes( | |||
| state: BeaconState, config: Eth2Config | |||
| ) -> Tuple[Eth1Data, ...]: | |||
| if (state.slot + 1) % config.SLOTS_PER_ETH1_VOTING_PERIOD == 0: | |||
| return tuple() | |||
| return HashableList.from_iterable((), state.eth1_data_votes.sedes) | |||
There was a problem hiding this comment.
Just to confirm, is HashableList(TElement) compatible with Tuple[Eth1Data, ...] in typing? I thought HashableList is Sequence[TElement]...?
There was a problem hiding this comment.
Ah, no, that's a mistake. I'm quite surprised that mypy didn't catch this. I'll fix the type hint.
| @@ -34,7 +34,7 @@ def test_activate_validator( | |||
| assert some_validator.activation_epoch == config.GENESIS_EPOCH | |||
| else: | |||
| some_validator = create_mock_validator( | |||
| pubkeys[: validator_count + 1], config, is_active=is_already_activated | |||
| index: ValidatorIndex = default_validator_index, | ||
| selection_proof: BLSSignature = EMPTY_SIGNATURE, | ||
| aggregate: Attestation = default_attestation, | ||
| ) -> None: | ||
| super().__init__( | ||
| ) -> TAggregateAndProof: |
There was a problem hiding this comment.
I'm curious, for mypy, is TypeVar required or we can simply use "AggregateAndProof" instead?
There was a problem hiding this comment.
It would make a difference if we subclass AggregateAndProof and don't override the classmethod. Then mypy would think AggregateAndProofSubclass.create would return a AggregateAndProof which wouldn't be correct.
jannikluhn
force-pushed
the
hashable-ssz-tests
branch
from
84fb90d to
845604f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #1283. CI got confused with dependency versions, so the tests were failing. I hope that a new PR makes them forget everything and install everything from scratch.
Edit: Didn't work :(
So it for some reason has
pyrsistent==0.15.6installed even thoughpy-sszrequirespyrsistent==0.15.4.Cute Animal Picture