Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Add support for Muir Glacier fork #1409

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

cburgdorf
Copy link
Contributor

@cburgdorf cburgdorf commented Dec 19, 2019

What was wrong?

Muir Glacier is expected to arrive shorty after the dawn of 2020. We aren't prepared yet.

How was it fixed?

  1. Upgrade to the next Py-EVM version (which isn't released yet)
  2. Configure MuirGlacierVM where the most recent VM is expected.
  3. Make Istanbul the minimal supported transaction type

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@cburgdorf cburgdorf force-pushed the christoph/feat/muir_glacier branch from f63dc61 to b5440f6 Compare December 19, 2019 09:24
@cburgdorf cburgdorf force-pushed the christoph/feat/muir_glacier branch from b5440f6 to 96e8455 Compare December 19, 2019 15:51
@cburgdorf cburgdorf requested a review from gsalgado December 19, 2019 16:04
Copy link
Contributor

@gsalgado gsalgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I wonder if there's a checklist of things we need to change in order to add support for a new fork? Would it be worth documenting that?

@veox
Copy link
Contributor

veox commented Dec 19, 2019

I wonder if there's a checklist of things we need to change in order to add support for a new fork?

@gsalgado I'd guess not, since that's only begun as a draft PR in py-evm. Not in py-evm -> probably not in trinity. Either way, I didn't find anything.

@cburgdorf
Copy link
Contributor Author

Yeah, I'll make sure to get us documentation to assist with forks in the future.

@cburgdorf cburgdorf merged commit 271ef6c into ethereum:master Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants