Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop auto detect testnets for IPCProvider #1206

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Drop auto detect testnets for IPCProvider #1206

merged 1 commit into from
Jan 14, 2019

Conversation

njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Jan 14, 2019 •
edited
Loading

What was wrong?

From Planned v5 changes issue

Stop automatically looking up a testnet connection in IPCProvider. Indicate that users should use something like from web3.auto.ropsten import w3 instead, if they want to auto-detect a testnet.

Related to Issue #722

How was it fixed?

Removed the testnet flag from get_default_ipc_path, and added a comment in the docs

Cute Animal Picture

image

@njgheorghita njgheorghita changed the title [WIP] - Drop auto detect testnets for IPCProvider Drop auto detect testnets for IPCProvider Jan 14, 2019
@njgheorghita njgheorghita merged commit 92463a2 into ethereum:master Jan 14, 2019
@njgheorghita njgheorghita deleted the drop-ipc-testnet-auto-detect branch January 14, 2019 19:39
@njgheorghita njgheorghita mentioned this pull request Jan 17, 2019
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipermerriam pipermerriam pipermerriam approved these changes

@carver carver Awaiting requested review from carver

@kclowes kclowes Awaiting requested review from kclowes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njgheorghita @pipermerriam