prevent ethpm import issues without ipfshttpclient
#2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttpclient`` dependency
fselmo
force-pushed
the
ethpm-import-issue
branch
from
cf91a19 to
a01987a
Compare
fselmo
commented
Jan 13, 2023
fselmo
commented
Jan 13, 2023
| @@ -30,6 +27,12 @@ | |||
| RegistryURIBackend, | |||
| ) | |||
|
|
|||
| try: | |||
| from ipfshttpclient.exceptions import ConnectionError as IpfsConnectionError | |||
There was a problem hiding this comment.
This was renamed to IpfsConnectionError because there is a builtin ConenctionError... so we'd be mistakenly catching an unwanted exception if the ipfshttpclient module is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2774
How was it fixed?
ipfshttpclientforethpmTodo:
Cute Animal Picture