New eth.sign and recovery hash generator #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You get a `bytes` object out, which will often be invalid ascii Kept toAscii for backwards compatibility
Also, bugfix odd-length hex that is not 0x prefixed
After removing old functionality: sha3 = compose(encode_hex, keccak, to_bytes)
Want to avoid confusion from sending in hex without 0x prefix, which could silently return a different result than you expect.
Plus: * Refactor argument test for None out to web3.utils.validation * Improved additional tests, and associated fixes
This was referenced Sep 14, 2017
pipermerriam
approved these changes
Sep 17, 2017
| "topics": [web3.fromAscii("test")], | ||
| "payload": web3.fromAscii(payloads[len(payloads) - 1]), | ||
| "topics": [topic], | ||
| "payload": web3.toHex(text=payloads[-1]), |
There was a problem hiding this comment.
Doesn't need to be cleaned up here, but it might be wise for us to remove the use of web3.toHex here in favor of using the eth_utils.encode_hex function so as to not make our tests dependent on this API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth.signwas ambiguous about the kind of data it received. It was also difficult to verify the message; users were completely on their own.How was it fixed?
eth.signnow follows the pattern of the other converters, by passing one of these:(bytesdata, hexstr='0x..', text='my msg')There is also a new hash generator
eth._recoveryMessageHashwhich adds the preamble and generates the hash thatecrecovertakes as a first argument. The preamble is the one defined by geth, a loose standard until EIP 191 is solidified.It looks like we won't get
ecrecoverfunctionality until we upgrade pyethereum.Also, I'll add docs when I get a 🚢
Cute Animal Picture